Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add curl_command as serverspec extension #89

Merged
merged 2 commits into from
Jan 20, 2025
Merged

add curl_command as serverspec extension #89

merged 2 commits into from
Jan 20, 2025

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jan 14, 2025

No description provided.

ekohl
ekohl reviewed Jan 14, 2025
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think explicitly opting in can make sense, but I'd like to see it documented (for example in README).

lib/voxpupuli/acceptance/serverspec_extensions/curl_command.rb
end

def body_as_json
MultiJson.load(body)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: serverspec itself now depends on multi_json so this should be acceptable.

@ehelms ehelms mentioned this pull request Jan 14, 2025
Merged
ekohl
ekohl reviewed Jan 18, 2025
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still like to see some instructions on using it, probably in README

@evgeni
Copy link
Member Author

evgeni commented Jan 18, 2025

@ekohl added README

@evgeni evgeni force-pushed the curl_command branch 3 times, most recently from 20a8256 to 2e55623 Compare January 18, 2025 15:39
@evgeni
Copy link
Member Author

evgeni commented Jan 18, 2025

The docs and the loading are not in sync (docs say default, code doesn't load by default)

@evgeni evgeni added the enhancement New feature or request label Jan 19, 2025
evgeni added 2 commits January 20, 2025 13:05
@evgeni
add curl_command as serverspec extension
3d555c0
@evgeni
make new_example produce a valid username in the metadata
f4d6c58 
otherwise the module is not found and Puppet reaches out to the forge
@evgeni evgeni merged commit b075362 into voxpupuli:master Jan 20, 2025
37 checks passed
@evgeni evgeni deleted the curl_command branch January 20, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

@ekohl ekohl ekohl left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgeni @ekohl @bastelfreak